New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(collapse): open editor not expand expected #196

Merged

wewoor merged 1 commit into main from fix/collapse

Jun 22, 2021

Collaborator

mortalYoung commented Jun 22, 2021

简介

修复 Open Editor 窗口展开的高度没有按照期望的问题

主要变更

原因是因为 fix(collapse): fix calc content height failed because of height: 100% #194 这个 PR 里面通过直接给 contentDom.style.height 赋值来设置内容物高度，但是这么赋值之后，下次一个去计算高度的时候，contentDom.getBoundingClientRect 拿到的高度就一直是之前赋值的高度了。所以通过判断是否为 config.grow === 0 来区别对待不同的 panel，grow 为 0 的 panel 不进行内容高度的赋值


          fix(collapse): open editor not expand expected

90e07e5

wewoor merged commit 2af530f into main

wewoor deleted the fix/collapse branch

June 22, 2021 10:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet